index: Allow FileNotFoundError to be handled at the top level #1646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorlin
force-pushed
the
victorlin/fix-augur-index-FileNotFoundError
branch
from
6bd9983
to
c2a1c64
Compare
victorlin
changed the title
The removed error handling is flawed: it assumes that FileNotFoundError can only come from a missing input file (--sequences). The reality is that FileNotFoundError can also come from a missing output directory (--output). The top-level exception handler parses the filepath from the error directly, which is accurate.
victorlin
force-pushed
the
victorlin/fix-augur-index-FileNotFoundError
branch
from
c2a1c64
to
296a6c6
Compare
|
Updated tests in force-push. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1646 +/- ##
==========================================
+ Coverage 71.14% 71.17% +0.03%
==========================================
Files 79 79
Lines 8273 8268 -5
Branches 2010 2010
==========================================
- Hits 5886 5885 -1
+ Misses 2099 2095 -4
Partials 288 288 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
The removed error handling is flawed: it assumes that FileNotFoundError can only come from a missing input file (--sequences). The reality is that FileNotFoundError can also come from a missing output directory (--output). The top-level exception handler parses the filepath from the error directly, which is accurate.
Related issue(s)
Fixes #1644
Checklist
Check if you need to add teststested locally that this works. I don't think adding a test is necessary in this case